Quoting Ville Syrjala (2018-02-14 19:21:08)
> From: Ville Syrjälä <ville.syrj...@linux.intel.com>
> 
> Use the new "COLOR_ENCODING" plane property to implement the
> XV_COLORSPACE port attribute for sprite Xv adaptors.
> 
> Cc: Jyri Sarha <jsa...@ti.com>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
> ---
> +void sna_crtc_set_sprite_colorspace(xf86CrtcPtr crtc,
> +                                   unsigned idx, int colorspace)
> +{
> +       struct plane *p;
> +
> +       assert(to_sna_crtc(crtc));

assert(colorspace < ARRAY_SIZE(p->color_encoding.values));

> +
> +       p = lookup_sprite(to_sna_crtc(crtc), idx);
> +
> +       if (!p->color_encoding.prop)
> +               return;
> +
> +       drmModeObjectSetProperty(to_sna(crtc->scrn)->kgem.fd,
> +                                p->id, DRM_MODE_OBJECT_PLANE,
> +                                p->color_encoding.prop,
> +                                p->color_encoding.values[colorspace]);

Does changing the property trigger an immediate update, or is that
deferred until the next SetPlane (or atomic update)?

It makes no difference to this patch, except we might redisplay the
image immediately rather than wait for the client?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to