[Intel-gfx] [PATCH igt 03/16] lib: Always set mismatching index for igt_find_crc_mismatch

[Chris Wilson]

igt_debugfs.c: In function 'igt_assert_crc_equal':
igt_debugfs.c:353:3: warning: 'index' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
igt_debugfs.c: In function 'igt_check_crc_equal':
igt_debugfs.c:375:3: warning: 'index' may be used uninitialized in this 
function [-Wmaybe-uninitialized]

Fixes: 7422d7540a3b ("lib/igt_debugfs: Introduce CRC check function, with logic 
made common")
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
 lib/igt_debugfs.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 09d42ea0..8adc02e9 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -325,12 +325,10 @@ bool igt_debugfs_search(int device, const char *filename, 
const char *substring)
 static bool igt_find_crc_mismatch(const igt_crc_t *a, const igt_crc_t *b,
                                  int *index)
 {
+       int nwords = min(a->n_words, b->n_words);
        int i;
 
-       if (a->n_words != b->n_words)
-               return true;
-
-       for (i = 0; i < a->n_words; i++) {
+       for (i = 0; i < nwords; i++) {
                if (a->crc[i] != b->crc[i]) {
                        if (index)
                                *index = i;
@@ -339,6 +337,12 @@ static bool igt_find_crc_mismatch(const igt_crc_t *a, 
const igt_crc_t *b,
                }
        }
 
+       if (a->n_words != b->n_words) {
+               if (index)
+                       *index = i;
+               return true;
+       }
+
        return false;
 }
 
-- 
2.16.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx