Quoting Paulo Zanoni (2018-03-23 17:24:16)
> From: Manasi Navare <manasi.d.nav...@intel.com>
> 
> This table is used for voltage swing programming sequence during DDI
> Buffer initialization for MG PHY DDI Buffers on Icelake.

Except it is not used at all...

drivers/gpu/drm/i915/intel_ddi.c:601:46: error: ‘icl_mg_phy_ddi_translations’ 
defined but not used [-Werror=unused-const-variable=]
 static const struct icl_mg_phy_ddi_buf_trans icl_mg_phy_ddi_translations[] = {
                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/intel_ddi.c:581:49: error: 
‘icl_combo_phy_ddi_translations_edp_1_05V’ defined but not used 
[-Werror=unused-const-variable=]
 static const struct icl_combo_phy_ddi_buf_trans 
icl_combo_phy_ddi_translations_edp_1_05V[] = {
                                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/intel_ddi.c:565:49: error: 
‘icl_combo_phy_ddi_translations_dp_hdmi_1_05V’ defined but not used 
[-Werror=unused-const-variable=]
 static const struct icl_combo_phy_ddi_buf_trans 
icl_combo_phy_ddi_translations_dp_hdmi_1_05V[] = {
                                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/intel_ddi.c:550:49: error: 
‘icl_combo_phy_ddi_translations_edp_0_95V’ defined but not used 
[-Werror=unused-const-variable=]
 static const struct icl_combo_phy_ddi_buf_trans 
icl_combo_phy_ddi_translations_edp_0_95V[] = {
                                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/intel_ddi.c:534:49: error: 
‘icl_combo_phy_ddi_translations_dp_hdmi_0_95V’ defined but not used 
[-Werror=unused-const-variable=]
 static const struct icl_combo_phy_ddi_buf_trans 
icl_combo_phy_ddi_translations_dp_hdmi_0_95V[] = {
                                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/intel_ddi.c:519:49: error: 
‘icl_combo_phy_ddi_translations_edp_0_85V’ defined but not used 
[-Werror=unused-const-variable=]
 static const struct icl_combo_phy_ddi_buf_trans 
icl_combo_phy_ddi_translations_edp_0_85V[] = {
                                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/intel_ddi.c:503:49: error: 
‘icl_combo_phy_ddi_translations_dp_hdmi_0_85V’ defined but not used 
[-Werror=unused-const-variable=]
 static const struct icl_combo_phy_ddi_buf_trans 
icl_combo_phy_ddi_translations_dp_hdmi_0_85V[] = {
                                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


> v2 (from Paulo):
> * Fix white space issues.
> 
> Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
> Cc: Jani Nikula <jani.nik...@linux.intel.com>
> Reviewed-by: Paulo Zanoni <paulo.r.zan...@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zan...@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c 
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 229b9d5250c4..359acbfec4b1 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -592,6 +592,26 @@ static const struct icl_combo_phy_ddi_buf_trans 
> icl_combo_phy_ddi_translations_e
>         { 0x0, 0x00, 0x00 },    /* 350         0.0   */
>  };
>  
> +struct icl_mg_phy_ddi_buf_trans {
> +       u32 cri_txdeemph_override_5_0;
> +       u32 cri_txdeemph_override_11_6;
> +       u32 cri_txdeemph_override_17_12;
> +};
> +
> +static const struct icl_mg_phy_ddi_buf_trans icl_mg_phy_ddi_translations[] = 
> {
> +                               /* Voltage swing  pre-emphasis */
> +       { 0x0, 0x1B, 0x00 },    /* 0              0   */
> +       { 0x0, 0x23, 0x08 },    /* 0              1   */
> +       { 0x0, 0x2D, 0x12 },    /* 0              2   */
> +       { 0x0, 0x00, 0x00 },    /* 0              3   */
> +       { 0x0, 0x23, 0x00 },    /* 1              0   */
> +       { 0x0, 0x2B, 0x09 },    /* 1              1   */
> +       { 0x0, 0x2E, 0x11 },    /* 1              2   */
> +       { 0x0, 0x2F, 0x00 },    /* 2              0   */
> +       { 0x0, 0x33, 0x0C },    /* 2              1   */
> +       { 0x0, 0x00, 0x00 },    /* 3              0   */
> +};
> +
>  static const struct ddi_buf_trans *
>  bdw_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
>  {
> -- 
> 2.14.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to