On Tue, 2018-05-22 at 07:37 -0700, Tarun Vyas wrote: > On Fri, May 11, 2018 at 12:51:45PM -0700, Dhinakaran Pandiyan wrote: > > > > While touching the code around this, I noticed that absence of ALPM > > capability does not stop us from enabling PSR2. But, the spec > > unambiguously states that ALPM is required for PSR2 and so does > > this > > commit that introduced this code > > > > drm/i915/psr: enable ALPM for psr2 > > > > As per edp1.4 spec , alpm is required for psr2 operation as > > it's > > used for all psr2 main link power down management and alpm > > enable > > bit must be set for psr2 operation. > > > Since, the code introduced by "drm/i915/psr: enable ALPM for psr2" > enables PSR2 even if ALPM isn't supported, can we add the "Fixes" tag > here ?
I thought about it. I don't think PSR2 was enabled upstream by default, so we should be good without Fixes. And I didn't investigate if the original commit missed the ALPM check or if it was mangled later. _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
