On Sun, 20 May 2018, Tarun Vyas <[email protected]> wrote: > On Fri, May 11, 2018 at 12:51:43PM -0700, Dhinakaran Pandiyan wrote: >> intel_dp->psr_dpcd already has the required values. >> >> Cc: Jose Roberto de Souza <[email protected]> >> Signed-off-by: Dhinakaran Pandiyan <[email protected]> >> --- >> drivers/gpu/drm/i915/intel_psr.c | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_psr.c >> b/drivers/gpu/drm/i915/intel_psr.c >> index 61ade81576f5..381dbdbf30f4 100644 >> --- a/drivers/gpu/drm/i915/intel_psr.c >> +++ b/drivers/gpu/drm/i915/intel_psr.c >> @@ -201,15 +201,6 @@ void intel_psr_irq_handler(struct drm_i915_private >> *dev_priv, u32 psr_iir) >> } >> } >> >> -static bool intel_dp_get_y_coord_required(struct intel_dp *intel_dp) >> -{ >> - uint8_t psr_caps = 0; >> - >> - if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_CAPS, &psr_caps) != 1) >> - return false; >> - return psr_caps & DP_PSR2_SU_Y_COORDINATE_REQUIRED; >> -} >> - >> static bool intel_dp_get_colorimetry_status(struct intel_dp *intel_dp) >> { >> uint8_t dprx = 0; >> @@ -275,7 +266,7 @@ void intel_psr_init_dpcd(struct intel_dp *intel_dp) >> * GTC first. >> */ >> dev_priv->psr.sink_psr2_support = >> - intel_dp_get_y_coord_required(intel_dp); >> + intel_dp->psr_dpcd[1] & >> DP_PSR2_SU_Y_COORDINATE_REQUIRED; >> DRM_DEBUG_KMS("PSR2 %ssupported\n", >> dev_priv->psr.sink_psr2_support ? "" : "not "); > The drm_dp_dpcd_read itself reads the first 2 PSR DPCD bytes which is what is > needed. Also, no other callers of intel_dp_get_y_coord_required exist. So, > > Reviewed-by: Tarun Vyas <[email protected]>
The rest of the patches in the series pushed to dinq as well, thanks for the patches and review. BR, Jani. >> >> -- >> 2.14.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
