Quoting Matthew Auld (2018-05-31 15:43:14) > On 31 May 2018 at 12:35, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > > From: Jon Bloomfield <jon.bloomfi...@intel.com> > > > > We can set a bit inside the ppGTT PTE to indicate a page is read-only; > > writes from the GPU will be discarded. We can use this to protect pages > > and in particular support read-only userptr mappings (necessary for > > importing PROT_READ vma). > > > > Signed-off-by: Jon Bloomfield <jon.bloomfi...@intel.com> > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > > Cc: Matthew Auld <matthew.william.a...@gmail.com> > > Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > > fwiw I didn't see any surprises with ro 2M/64K PTEs when testing locally. > > For the series: > Reviewed-by: Matthew Auld <matthew.william.a...@gmail.com>
I think I'd like to see a selftest also exercising the ro nature before pushing. Thanks for the review, stick around there'll be another patch to come :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
