On Thu, 29 Nov 2012 13:42:17 +0100 Daniel Vetter <[email protected]> wrote:
> On Wed, Nov 14, 2012 at 07:11:24PM +0000, Chris Wilson wrote: > > Due to a discrepancy between the sleep time and the amount of time > > we spend waiting inside the wait_event_timeout, it is possible that > > we end up computing that negative time remains in the wait_ioctl. > > This is obviously a bogus result to return to userspace, and > > triggers a WARN, so we need to fix up the value before propagating > > it back. > > > > Signed-off-by: Chris Wilson <[email protected]> > > Cc: Ben Widawsky <[email protected]> > > Ben, can you pls take a look at this and smash an r-b on it if you're > ok? > > Thanks, Daniel I want the real bug fixed! I do suspect it's a test bug, but I'd prefer not to slap an r-b on until I can pass the original problematic test. This just fixes an annoying WARN, which isn't super important to me because it's not a regression (since it existed since day 1), and no userspace really cares yet other than IGT. I did review the patch previously, and it looks fine. So, the r-b is pending. _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
