On Fri, Aug 10, 2018 at 10:21:59AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2018-08-10 10:11:29)
> > On Fri, Aug 10, 2018 at 10:02:46AM +0100, Chris Wilson wrote:
> > > Reloading the module may impact subsequent tests by destabilising the
> > > system. As we do for BAT, if we want to test reloads, it should be
> > > handled explicitly at the end of the run, rather than placed at random
> > > in the middle of the test list.
> > > 
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> > > Cc: Tomi Sarvela <tomi.p.sarv...@intel.com>
> > > ---
> > >  tests/intel-ci/blacklist.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > > index 1d1652964..066a5c014 100644
> > > --- a/tests/intel-ci/blacklist.txt
> > > +++ b/tests/intel-ci/blacklist.txt
> > > @@ -2,6 +2,7 @@ igt@meta_test(@.*)?
> > >  ###############################################
> > >  # GEM
> > >  ###############################################
> > > +igt@drv_module_reload(@.*)?
> > 
> > "GEM"?
> 
> That didn't apply to the selftests or drm_mm, so I thought it was the
> usual misleading comment.
>  
> > Comment the line with the explanation from the commit message.
> 
> Where are comments allowed?

I believe Tomi's handling of blacklist.txt considers anything
beginning with # a comment.


-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to