Quoting Tvrtko Ursulin (2018-09-21 11:00:06) > > On 20/09/2018 20:59, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-09-20 15:21:47) > >> > >> On 19/09/2018 20:55, Chris Wilson wrote: > >>> Fix up the error unwind for logical_ring_init() failing by moving the > >> > >> Could you say in the commit what was broken? > > > > We didn't cleanup all the state we allocated in the caller. > > That was kind of obvious, but it would have been helpful to the reviewer > at least, if not to the commit message quality itself, to say what exactly.
I hope the addendum in the commitmsg was helpful. -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
