Quoting Tvrtko Ursulin (2018-11-30 17:44:07) > From: Tvrtko Ursulin <[email protected]> > > We stopped re-applying the GT workarounds after engine reset since commit > 59b449d5c82a ("drm/i915: Split out functions for different kinds of > workarounds"). > > Issue with this is that some of the GT workarounds live in the MMIO space > which gets lost during engine resets. So far the registers in 0x2xxx and > 0xbxxx address range have been identified to be affected. > > This losing of applied workarounds has obvious negative effects and can > even lead to hard system hangs (see the linked Bugzilla). > > Rather than just restoring this re-application, because we have also > observed that it is not safe to just re-write all GT workarounds after > engine resets (GPU might be live and weird hardware states can happen), > we introduce a new class of per-engine workarounds and move only the > affected GT workarounds over. > > Using the framework introduced in the previous patch, we therefore after > engine reset, re-apply only the workarounds living in the affected MMIO > address ranges. > > Signed-off-by: Tvrtko Ursulin <[email protected]> > Bugzilla: https://bugzilla.freedesktop.org/show_bug.cgi?id=107945 > Fixes: 59b449d5c82a ("drm/i915: Split out functions for different kinds of > workarounds") > Cc: Mika Kuoppala <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Cc: Chris Wilson <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: Joonas Lahtinen <[email protected]> > Cc: Rodrigo Vivi <[email protected]> > Cc: [email protected]
Give or take the naming arguments, Reviewed-by: Chris Wilson <[email protected]> -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
