On 4/9/19 3:11 PM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-09 22:31:01) >> diff --git a/drivers/gpu/drm/i915/i915_gem.c >> b/drivers/gpu/drm/i915/i915_gem.c >> index bf3d12f94365..160959785589 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.c >> +++ b/drivers/gpu/drm/i915/i915_gem.c >> @@ -4508,6 +4508,8 @@ void i915_gem_resume(struct drm_i915_private *i915) >> i915_gem_restore_gtt_mappings(i915); >> i915_gem_restore_fences(i915); >> >> + intel_uc_restore_ggtt_mapping(i915); > No need, right? The fw ggtt binding is only temporary for the dma xfer.
On resume we re-init the uc hardware and perform the upload again. Since I moved the binding to the uc init phase I had to restore the mapping here. And it should not have been called unconditionally... Fernando > -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
