On Wed, Jul 17, 2013 at 06:55:04AM +0200, Daniel Vetter wrote: > There seems to be no limit to the amount of gunk the firmware can > leave behind. Some platforms leave pch dplls on which are not in > active use at all. The example in the bug report is a Apple Macbook > Pro. > > Note that this escape scrunity of the hw state checker until we've > tried to use this enabled, but unused pll since we did only check for > the inverse case of a in-used, but disabled pll. > > v2: Add a WARN in the pll state checker which would have caught this > case. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66952 > Reported-and-tested-by: shui yangwei <yangweix.s...@intel.com> > Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>
Plonk it in intel_sanitize_plls(), and preferably move all the sanitze encoder/crtc/pll into intel_sanitize_display() (in a later patch), so that intel_modeset_setup_hw_state() is not quite so broken up. Other than that minor request, Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
