On Thu, 2020-08-06 at 19:31 +0100, Chris Wilson wrote:
> As we are about to write into the mmap'ed pointer using memset, we
> need
> to specify PROT_WRITE [if we only say PROT_READ, then the memset
> should
> generate a SIGSEGV].
>
Thank you for fixing that.
> Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
> Signed-off-by: Chris Wilson <[email protected]>
> Cc: Ramalingam C <[email protected]>
> Cc: Dominik Grzegorzek <[email protected]>
> ---
> tests/i915/gem_caching.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
> index 1d8989db7..894c4b12e 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -282,7 +282,7 @@ igt_main
> val2 = i + 63;
> cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf-
> >handle,
> 0, scratch_buf-
> >surface[0].size,
> - PROT_READ);
> + PROT_WRITE);
>
> memset(cpu_ptr + start, val2, len);
>
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
