Quoting Lucas De Marchi (2020-10-12 17:55:03) > On Fri, Jul 31, 2020 at 12:23:57AM -0700, Siddiqui, Ayaz A wrote: > > > > > >> -----Original Message----- > >> From: Siddiqui, Ayaz A <[email protected]> > >> Sent: Wednesday, July 29, 2020 3:56 PM > >> To: [email protected] > >> Cc: Siddiqui, Ayaz A <[email protected]>; Chris Wilson <chris@chris- > >> wilson.co.uk>; De Marchi, Lucas <[email protected]>; Lis, Tomasz > >> <[email protected]>; Roper, Matthew D <[email protected]>; > >> Joonas Lahtinen <[email protected]>; Francisco Jerez > >> <[email protected]>; Mathew, Alwin <[email protected]>; Mcguire, > >> Russell W <[email protected]>; Spruit, Neil R > >> <[email protected]>; Zhou, Cheng <[email protected]>; Benemelis, > >> Mike G <[email protected]> > >> Subject: [PATCH v4 1/1] drm/i915/gt: Initialize reserved and unspecified > >> MOCS > >> indices > >> > >> In order to avoid functional breakage of mis-programmed applications that > >> have > >> grown to depend on unused MOCS entries, we are programming those entries to > >> be equal to fully cached ("L3 + LLC") entry. > >> > >> These reserved and unspecified entries should not be used as they may be > >> changed to less performant variants with better coherency in the future if > >> more > >> entries are needed. > >> > >> V2: As suggested by Lucas De Marchi to utilise __init_mocs_table for > >> programming default value, setting I915_MOCS_PTE index of tgl_mocs_table > >> with desired value. > >> > >> Cc: Chris Wilson <[email protected]> > >> Cc: Lucas De Marchi <[email protected]> > >> Cc: Tomasz Lis <[email protected]> > >> Cc: Matt Roper <[email protected]> > >> Cc: Joonas Lahtinen <[email protected]> > >> Cc: Francisco Jerez <[email protected]> > >> Cc: Mathew Alwin <[email protected]> > >> Cc: Mcguire Russell W <[email protected]> > >> Cc: Spruit Neil R <[email protected]> > >> Cc: Zhou Cheng <[email protected]> > >> Cc: Benemelis Mike G <[email protected]> > >> > >> Signed-off-by: Ayaz A Siddiqui <[email protected]> > >> Reviewed-by: Lucas De Marchi <[email protected]> > >> --- > >> drivers/gpu/drm/i915/gt/intel_mocs.c | 15 +++++++++++---- > >> 1 file changed, 11 insertions(+), 4 deletions(-) > >> > > > >I'm getting a false failure with this patch , which I tested locally and its > >passing > >with this patch. I think that this failure is blocking merge of this patch. > >Can Someone please let me know how to proceed in this case for merging? > > If it's a false failure, you can go ahead and merge it. Better to reply > to the CI email how is it unrelated.
I would say the kms_frontbuffer_tracking is genuine fail as that is very cache sensitive. And I've just pushed this to upstream, oops, so now the problem is a little more urgent. -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
