On Tue, Oct 01, 2013 at 06:02:09PM +0300, [email protected] wrote: > Chris asked for some renames and assertions during v1. While adding those I > noticed that what I did in the original patch 02 didn't match quite so well > with the assertions. So I modified patch 02 a bit, and that caused quite a bit > of bit of rebase issues for most of the other patches, so I figured it's > better > to repost the whole thing. > > Changes from v1: > - Move the primary disable/enable calls inside intel_crtc->active checks > in intel_update_plane/intel_disable_plane. That also ate up patch 03 from > the original series. > - Add primary_disabled WARNs > - Rename primary plane funcs > - Flush primary plane changes from sprite code > - Add a POSTING_READ() to intel_flush_primary_plane. This shouldn't really > be necessary now that I think about it some more. So we might want to drop > that change...
Looks good, very good, to me. Even with throwing up over FBC, Reviewed-by: Chris Wilson <[email protected]> except for 08/12: drm/i915: Enable/disable IPS when primary is enabled/disabled For which the code looks ok, but only merits an Acked-by: Chris Wilson <[email protected]> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
