On Wed, Aug 28, 2013 at 10:59:42AM +0200, Daniel Vetter wrote:
> We already have a big splashing *ERROR* for all the relevant cases of
> hangs, so this one here is redudant. And it results in an unclean
> dmesg when running with simulated hangs. Regression has been
> introduced in
> 
> commit 05407ff889ceebe383aa5907219f86582ef96b72
> Author: Mika Kuoppala <[email protected]>
> Date:   Thu May 30 09:04:29 2013 +0300
> 
>     drm/i915: detect hang using per ring hangcheck_score
> 
> Cc: Mika Kuoppala <[email protected]>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68641
> Signed-off-by: Daniel Vetter <[email protected]>

Tested-by: lu hua <[email protected]>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index a03b445..4c6853f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2027,9 +2027,9 @@ static void i915_hangcheck_elapsed(unsigned long data)
>  
>       for_each_ring(ring, dev_priv, i) {
>               if (ring->hangcheck.score > FIRE) {
> -                     DRM_ERROR("%s on %s\n",
> -                               stuck[i] ? "stuck" : "no progress",
> -                               ring->name);
> +                     DRM_INFO("%s on %s\n",
> +                              stuck[i] ? "stuck" : "no progress",
> +                              ring->name);
>                       rings_hung++;
>               }
>       }
> -- 
> 1.8.4.rc3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to