From: Ville Syrjälä <[email protected]>

Read out the gamma/degamma LUT on bdw+. Now that the
{pre,post}_csc_lut match the hardware LUT size even
in split gamma mode this is trivial.

v2: deal with {pre,post}_csc_lut
    split gamma is no longer a problem

Reviewed-by: Uma Shankar <[email protected]> #v1
Signed-off-by: Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_color.c | 40 ++++++++++++++++++----
 1 file changed, 34 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_color.c 
b/drivers/gpu/drm/i915/display/intel_color.c
index e0a0b82ae52a..63e6665b0ec5 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -2187,14 +2187,11 @@ static struct drm_property_blob *bdw_read_lut_10(struct 
intel_crtc *crtc,
                                                 u32 prec_index)
 {
        struct drm_i915_private *i915 = to_i915(crtc->base.dev);
-       int i, hw_lut_size = ivb_lut_10_size(prec_index);
-       int lut_size = INTEL_INFO(i915)->display.color.gamma_lut_size;
+       int i, lut_size = ivb_lut_10_size(prec_index);
        enum pipe pipe = crtc->pipe;
        struct drm_property_blob *blob;
        struct drm_color_lut *lut;
 
-       drm_WARN_ON(&i915->drm, lut_size != hw_lut_size);
-
        blob = drm_property_create_blob(&i915->drm,
                                        sizeof(lut[0]) * lut_size,
                                        NULL);
@@ -2217,6 +2214,37 @@ static struct drm_property_blob *bdw_read_lut_10(struct 
intel_crtc *crtc,
        return blob;
 }
 
+static void bdw_read_luts(struct intel_crtc_state *crtc_state)
+{
+       struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+       struct drm_property_blob **blob =
+               crtc_state->csc_mode & CSC_POSITION_BEFORE_GAMMA ?
+               &crtc_state->post_csc_lut : &crtc_state->pre_csc_lut;
+
+       if (!crtc_state->gamma_enable)
+               return;
+
+       switch (crtc_state->gamma_mode) {
+       case GAMMA_MODE_MODE_8BIT:
+               *blob = ilk_read_lut_8(crtc);
+               break;
+       case GAMMA_MODE_MODE_SPLIT:
+               crtc_state->pre_csc_lut =
+                       bdw_read_lut_10(crtc, PAL_PREC_SPLIT_MODE |
+                                       PAL_PREC_INDEX_VALUE(0));
+               crtc_state->post_csc_lut =
+                       bdw_read_lut_10(crtc, PAL_PREC_SPLIT_MODE |
+                                       PAL_PREC_INDEX_VALUE(512));
+               break;
+       case GAMMA_MODE_MODE_10BIT:
+               *blob = bdw_read_lut_10(crtc, PAL_PREC_INDEX_VALUE(0));
+               break;
+       default:
+               MISSING_CASE(crtc_state->gamma_mode);
+               break;
+       }
+}
+
 static struct drm_property_blob *glk_read_degamma_lut(struct intel_crtc *crtc)
 {
        struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
@@ -2384,7 +2412,7 @@ static const struct intel_color_funcs skl_color_funcs = {
        .color_commit_noarm = ilk_color_commit_noarm,
        .color_commit_arm = skl_color_commit_arm,
        .load_luts = bdw_load_luts,
-       .read_luts = NULL,
+       .read_luts = bdw_read_luts,
 };
 
 static const struct intel_color_funcs bdw_color_funcs = {
@@ -2392,7 +2420,7 @@ static const struct intel_color_funcs bdw_color_funcs = {
        .color_commit_noarm = ilk_color_commit_noarm,
        .color_commit_arm = hsw_color_commit_arm,
        .load_luts = bdw_load_luts,
-       .read_luts = NULL,
+       .read_luts = bdw_read_luts,
 };
 
 static const struct intel_color_funcs hsw_color_funcs = {
-- 
2.37.4

Reply via email to