On Thu, 10 Nov 2022, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > Satisfy my ocd and define ilk_lut_12p4_ldw() before ilk_lut_12p4_udw(). > That is the order all the other similar functions use. > > Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_color.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_color.c > b/drivers/gpu/drm/i915/display/intel_color.c > index 8e92eb61abac..9c259e144772 100644 > --- a/drivers/gpu/drm/i915/display/intel_color.c > +++ b/drivers/gpu/drm/i915/display/intel_color.c > @@ -482,14 +482,6 @@ static void ilk_lut_10_pack(struct drm_color_lut *entry, > u32 val) > entry->blue = > intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_10_BLUE_MASK, val), 10); > } > > -/* ilk+ "12.4" interpolated format (high 10 bits) */ > -static u32 ilk_lut_12p4_udw(const struct drm_color_lut *color) > -{ > - return REG_FIELD_PREP(PREC_PALETTE_12P4_RED_UDW_MASK, color->red >> 6) | > - REG_FIELD_PREP(PREC_PALETTE_12P4_GREEN_UDW_MASK, color->green > >> 6) | > - REG_FIELD_PREP(PREC_PALETTE_12P4_BLUE_UDW_MASK, color->blue >> > 6); > -} > - > /* ilk+ "12.4" interpolated format (low 6 bits) */ > static u32 ilk_lut_12p4_ldw(const struct drm_color_lut *color) > { > @@ -498,6 +490,14 @@ static u32 ilk_lut_12p4_ldw(const struct drm_color_lut > *color) > REG_FIELD_PREP(PREC_PALETTE_12P4_BLUE_LDW_MASK, color->blue & > 0x3f); > } > > +/* ilk+ "12.4" interpolated format (high 10 bits) */ > +static u32 ilk_lut_12p4_udw(const struct drm_color_lut *color) > +{ > + return REG_FIELD_PREP(PREC_PALETTE_12P4_RED_UDW_MASK, color->red >> 6) | > + REG_FIELD_PREP(PREC_PALETTE_12P4_GREEN_UDW_MASK, color->green > >> 6) | > + REG_FIELD_PREP(PREC_PALETTE_12P4_BLUE_UDW_MASK, color->blue >> > 6); > +} > + > static void ilk_lut_12p4_pack(struct drm_color_lut *entry, u32 ldw, u32 udw) > { > entry->red = REG_FIELD_GET(PREC_PALETTE_12P4_RED_UDW_MASK, udw) << 6 | -- Jani Nikula, Intel Open Source Graphics Center
