typo correction...
On Tue, 2022-11-22 at 12:13 -0800, Alan Previn Teres Alexis wrote:
> After a more comprehensive offline discussion with Daniele and Rodrigo,
> design direction was made to go with Option2
> where we elevate pxp to a global subsystem and within it it establish a
> pointer to the correct gt for pxp-controls. This
> also reflects the current HW architectures where the PXP feature (when viewed
> as a service for contexts and buffers) is
> global to all subsystems including any workload on any tile, despite its
> single control-knobs being only in the media
> tile (because PXP controls needs to be global to the GPU to avoid any races).
>
> This would mean we move 'struct intel_pxp' to be under i915 so that all
> subsystems that need to call into PXP would now
> pass in i915 as its parameter. PXP internally would have a pointer to the
> correct GT (media-tile for MTL and gt0 for
typo: "pass in i915->pxp as its parameter"
> prior).
>
> It would also mean that certain code will still look a little kludgy or needs
> attention:
> - power-related operations like init/fini and suspend/resume would now need
> to called either before or after all-gt
> equivalents to ensure proper flow.
> - KCR IRQ will although being a gt level IRQ will now require passing i915
> into the pxp subsystem.
>
> *NOTE: above list, even if i missed any, would still be nowhere near the
> amount of other external facing interfaces that
> would be called by global subsystems that would now look clean with i915->pxp
> as its param.
>
> ...alan
