On Thu, 2023-03-16 at 15:17 +0200, Imre Deak wrote: > The commit renaming icl_tc_phy_is_in_safe_mode() to > icl_tc_phy_take_ownership() didn't flip the function's return value > accordingly, fix this up. > > This didn't cause an actual problem besides state check errors, since > the function is only used during HW readout.
Reviewed-by: José Roberto de Souza <[email protected]> > > Cc: José Roberto de Souza <[email protected]> > Fixes: f53979d68a77 ("drm/i915/display/tc: Rename safe_mode functions > ownership") > Signed-off-by: Imre Deak <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_tc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_tc.c > b/drivers/gpu/drm/i915/display/intel_tc.c > index 0b6fe96ab4759..fd826b9657e93 100644 > --- a/drivers/gpu/drm/i915/display/intel_tc.c > +++ b/drivers/gpu/drm/i915/display/intel_tc.c > @@ -418,9 +418,9 @@ static bool icl_tc_phy_is_owned(struct intel_digital_port > *dig_port) > val = intel_de_read(i915, PORT_TX_DFLEXDPCSSS(dig_port->tc_phy_fia)); > if (val == 0xffffffff) { > drm_dbg_kms(&i915->drm, > - "Port %s: PHY in TCCOLD, assume safe mode\n", > + "Port %s: PHY in TCCOLD, assume not owned\n", > dig_port->tc_port_name); > - return true; > + return false; > } > > return val & DP_PHY_MODE_STATUS_NOT_SAFE(dig_port->tc_phy_fia_idx);
