On Wed, Aug 23, 2023 at 10:07:27AM -0700, Lucas De Marchi wrote: > From: Gustavo Sousa <[email protected]> > > Hotplug setup for Xe2_LPD differs from Xe_LPD+ by the fact that the > extra programming for hotplug inversion and DDI HPD filter duration is > not necessary anymore. As mtp_hpd_irq_setup() is reasonably small, > prefer to fork it into a new function for Xe2_LPD instead of adding a > platform check. > > BSpec: 68970
It might be worth adding 69940 to the list here, since that's useful for confirming the hpd pin => bit mapping. > Signed-off-by: Gustavo Sousa <[email protected]> > Signed-off-by: Lucas De Marchi <[email protected]> > --- > .../gpu/drm/i915/display/intel_hotplug_irq.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c > b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c > index f76b9deb64b4..74aea0d8d9ae 100644 > --- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c > +++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c > @@ -163,7 +163,9 @@ static void intel_hpd_init_pins(struct drm_i915_private > *dev_priv) > (!HAS_PCH_SPLIT(dev_priv) || HAS_PCH_NOP(dev_priv))) > return; > > - if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) > + if (INTEL_PCH_TYPE(dev_priv) >= PCH_LNL) > + hpd->pch_hpd = hpd_mtp; > + else if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) > hpd->pch_hpd = hpd_sde_dg1; > else if (INTEL_PCH_TYPE(dev_priv) >= PCH_MTP) > hpd->pch_hpd = hpd_mtp; > @@ -1061,6 +1063,19 @@ static void mtp_hpd_irq_setup(struct drm_i915_private > *i915) > mtp_tc_hpd_detection_setup(i915); > } > > +static void xe2lpd_sde_hpd_irq_setup(struct drm_i915_private *i915) > +{ > + u32 hotplug_irqs, enabled_irqs; > + > + enabled_irqs = intel_hpd_enabled_irqs(i915, > i915->display.hotplug.pch_hpd); > + hotplug_irqs = intel_hpd_hotplug_irqs(i915, > i915->display.hotplug.pch_hpd); > + > + ibx_display_interrupt_update(i915, hotplug_irqs, enabled_irqs); > + > + mtp_ddi_hpd_detection_setup(i915); > + mtp_tc_hpd_detection_setup(i915); > +} > + > static bool is_xelpdp_pica_hpd_pin(enum hpd_pin hpd_pin) > { > return hpd_pin >= HPD_PORT_TC1 && hpd_pin <= HPD_PORT_TC4; > @@ -1120,6 +1135,8 @@ static void xelpdp_hpd_irq_setup(struct > drm_i915_private *i915) > > xelpdp_pica_hpd_detection_setup(i915); > > + if (INTEL_PCH_TYPE(i915) >= PCH_LNL) > + xe2lpd_sde_hpd_irq_setup(i915); > if (INTEL_PCH_TYPE(i915) >= PCH_MTP) I think we want an 'else if' here. Matt > mtp_hpd_irq_setup(i915); > } > -- > 2.40.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
