Hi Tvrtko, > On 09/10/2023 18:29, Jonathan Cavitt wrote: > > For the gt_tlb live selftest, when operating on the GSC engine, > > increase the timeout from 10 ms to 200 ms because the GSC > > engine is a bit slower than the rest. > > And others from 10ms to 20ms. By accident or deliberate?
yes, accident :-) Andi > > > Signed-off-by: Jonathan Cavitt <[email protected]> > > --- > > drivers/gpu/drm/i915/gt/selftest_tlb.c | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/selftest_tlb.c > > b/drivers/gpu/drm/i915/gt/selftest_tlb.c > > index 7e41f69fc818f..24beb94aa7a37 100644 > > --- a/drivers/gpu/drm/i915/gt/selftest_tlb.c > > +++ b/drivers/gpu/drm/i915/gt/selftest_tlb.c > > @@ -136,8 +136,15 @@ pte_tlbinv(struct intel_context *ce, > > i915_request_get(rq); > > i915_request_add(rq); > > - /* Short sleep to sanitycheck the batch is spinning before we begin */ > > - msleep(10); > > + /* > > + * Short sleep to sanitycheck the batch is spinning before we begin. > > + * FIXME: Why is GSC so slow? > > + */ > > + if (ce->engine->class == OTHER_CLASS) > > + msleep(200); > > + else > > + msleep(20); > > + > > if (va == vb) { > > if (!i915_request_completed(rq)) { > > pr_err("%s(%s): Semaphore sanitycheck failed %llx, with > > alignment %llx, using PTE size %x (phys %x, sg %x)\n",
