On Tue, Apr 30, 2024 at 01:10:00PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_AUX_DATA register macro.
> 
> Signed-off-by: Jani Nikula <[email protected]>

Reviewed-by: Rodrigo Vivi <[email protected]>

> ---
>  drivers/gpu/drm/i915/display/intel_psr.c      | 2 +-
>  drivers/gpu/drm/i915/display/intel_psr_regs.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c 
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index daeb1b65a2e5..5fe9feddc0e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -332,7 +332,7 @@ static i915_reg_t psr_aux_data_reg(struct 
> drm_i915_private *dev_priv,
>                                  enum transcoder cpu_transcoder, int i)
>  {
>       if (DISPLAY_VER(dev_priv) >= 8)
> -             return EDP_PSR_AUX_DATA(cpu_transcoder, i);
> +             return EDP_PSR_AUX_DATA(dev_priv, cpu_transcoder, i);
>       else
>               return HSW_SRD_AUX_DATA(i);
>  }
> diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h 
> b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> index a4f785bcf605..6a6d7de901bc 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> @@ -96,7 +96,7 @@
>  #define HSW_SRD_AUX_DATA(i)                  _MMIO(0x64814 + (i) * 4) /* 5 
> registers */
>  #define _SRD_AUX_DATA_A                              0x60814
>  #define _SRD_AUX_DATA_EDP                    0x6f814
> -#define EDP_PSR_AUX_DATA(tran, i)            _MMIO_TRANS2(dev_priv, tran, 
> _SRD_AUX_DATA_A + (i) * 4) /* 5 registers */
> +#define EDP_PSR_AUX_DATA(dev_priv, tran, i)          _MMIO_TRANS2(dev_priv, 
> tran, _SRD_AUX_DATA_A + (i) * 4) /* 5 registers */
>  
>  #define HSW_SRD_STATUS                               _MMIO(0x64840)
>  #define _SRD_STATUS_A                                0x60840
> -- 
> 2.39.2
> 

Reply via email to