On Tue, May 06, 2025 at 08:25:01PM +0530, Mitul Golani wrote:
> From: Ankit Nautiyal <ankit.k.nauti...@intel.com>
>
> Correct the adjustment required for fixed refresh rate mode for Display
> < 13. The vblank delay must be added and not subtracted to get the fixed
> rr vtotal.
>
> Fixes: bef1e60c7087 ("drm/i915/vrr: Prepare for fixed refresh rate timings")
> Cc: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
> Signed-off-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vrr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index c6565baf815a..45445198129f 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -263,7 +263,7 @@ int intel_vrr_fixed_rr_vtotal(const struct
> intel_crtc_state *crtc_state)
> if (DISPLAY_VER(display) >= 13)
> return crtc_vtotal;
> else
> - return crtc_vtotal -
> + return crtc_vtotal +
> intel_vrr_real_vblank_delay(crtc_state);
This change looks wrong. This serves the same purpose as the
the subtraction in intel_vrr_compute_config_late().
> }
>
> --
> 2.48.1
--
Ville Syrjälä
Intel
