On Thu, 02 Oct 2025, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > intel_fb_bo_framebuffer_init() doesn't do anything with the passed > framebuffer. Don't pass it therefore. > > Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_fb.c | 2 +- > drivers/gpu/drm/i915/display/intel_fb_bo.c | 3 +-- > drivers/gpu/drm/i915/display/intel_fb_bo.h | 3 +-- > drivers/gpu/drm/xe/display/intel_fb_bo.c | 3 +-- > 4 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fb.c > b/drivers/gpu/drm/i915/display/intel_fb.c > index c5bbca7f2e8b..4c8de8b54c45 100644 > --- a/drivers/gpu/drm/i915/display/intel_fb.c > +++ b/drivers/gpu/drm/i915/display/intel_fb.c > @@ -2226,7 +2226,7 @@ int intel_framebuffer_init(struct intel_framebuffer > *intel_fb, > if (!intel_fb->frontbuffer) > return -ENOMEM; > > - ret = intel_fb_bo_framebuffer_init(fb, obj, mode_cmd); > + ret = intel_fb_bo_framebuffer_init(obj, mode_cmd); > if (ret) > goto err_frontbuffer_put; > > diff --git a/drivers/gpu/drm/i915/display/intel_fb_bo.c > b/drivers/gpu/drm/i915/display/intel_fb_bo.c > index b0e8b89f7ce8..7336d7294a7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_fb_bo.c > +++ b/drivers/gpu/drm/i915/display/intel_fb_bo.c > @@ -18,8 +18,7 @@ void intel_fb_bo_framebuffer_fini(struct drm_gem_object > *obj) > /* Nothing to do for i915 */ > } > > -int intel_fb_bo_framebuffer_init(struct drm_framebuffer *fb, > - struct drm_gem_object *_obj, > +int intel_fb_bo_framebuffer_init(struct drm_gem_object *_obj, > struct drm_mode_fb_cmd2 *mode_cmd) > { > struct drm_i915_gem_object *obj = to_intel_bo(_obj); > diff --git a/drivers/gpu/drm/i915/display/intel_fb_bo.h > b/drivers/gpu/drm/i915/display/intel_fb_bo.h > index eefcb05a99f0..d775773c6c03 100644 > --- a/drivers/gpu/drm/i915/display/intel_fb_bo.h > +++ b/drivers/gpu/drm/i915/display/intel_fb_bo.h > @@ -14,8 +14,7 @@ struct drm_mode_fb_cmd2; > > void intel_fb_bo_framebuffer_fini(struct drm_gem_object *obj); > > -int intel_fb_bo_framebuffer_init(struct drm_framebuffer *fb, > - struct drm_gem_object *obj, > +int intel_fb_bo_framebuffer_init(struct drm_gem_object *obj, > struct drm_mode_fb_cmd2 *mode_cmd); > > struct drm_gem_object * > diff --git a/drivers/gpu/drm/xe/display/intel_fb_bo.c > b/drivers/gpu/drm/xe/display/intel_fb_bo.c > index ebdb22c9499d..db8b1a27b4de 100644 > --- a/drivers/gpu/drm/xe/display/intel_fb_bo.c > +++ b/drivers/gpu/drm/xe/display/intel_fb_bo.c > @@ -24,8 +24,7 @@ void intel_fb_bo_framebuffer_fini(struct drm_gem_object > *obj) > xe_bo_put(bo); > } > > -int intel_fb_bo_framebuffer_init(struct drm_framebuffer *fb, > - struct drm_gem_object *obj, > +int intel_fb_bo_framebuffer_init(struct drm_gem_object *obj, > struct drm_mode_fb_cmd2 *mode_cmd) > { > struct xe_bo *bo = gem_to_xe_bo(obj); -- Jani Nikula, Intel
