From: Ville Syrjälä <[email protected]>

Currently we use the implicit modifier fb creation path for fbdev,
but as we never call set_tiling on the bo it will always end up as
linear anyway. The rest of the code (eg. stride alignment) also
assumes that we'll use linear. Just select the linear modifier
explicitly.

Reviewed-by: Jani Nikula <[email protected]>
Signed-off-by: Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_fbdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c 
b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 3fbdf75415cc..51d3d87caf43 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -214,12 +214,14 @@ static void intel_fbdev_fill_mode_cmd(struct 
drm_fb_helper_surface_size *sizes,
        if (sizes->surface_bpp == 24)
                sizes->surface_bpp = 32;
 
+       mode_cmd->flags = DRM_MODE_FB_MODIFIERS;
        mode_cmd->width = sizes->surface_width;
        mode_cmd->height = sizes->surface_height;
 
        mode_cmd->pitches[0] = ALIGN(mode_cmd->width * 
DIV_ROUND_UP(sizes->surface_bpp, 8), 64);
        mode_cmd->pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
                                                           
sizes->surface_depth);
+       mode_cmd->modifier[0] = DRM_FORMAT_MOD_LINEAR;
 }
 
 static struct intel_framebuffer *
-- 
2.49.1

Reply via email to