On 4/14/2014 2:35 PM, Daniel Vetter wrote:
On Mon, Apr 14, 2014 at 01:24:43PM +0530, Kumar, Shobhit wrote:
On 4/14/2014 12:32 PM, Daniel Vetter wrote:
On Mon, Apr 14, 2014 at 11:00:34AM +0530, Shobhit Kumar wrote:
The parser extracts the config block(#52) and sequence(#53) data
and store in private data structures.

v2: Address review comments by Jani
     - adjust code for the structure changes for bdb_mipi_config
     - add boundry and buffer overflow checks as suggested
     - use kmemdup instead of kmalloc and memcpy

v3: More strict check while parsing VBT
     - Ensure that at anytime we do not go beyond sequence block
       while parsing
     - On unknown element fail the whole parsing

v4: Style changes and spell check mostly as suggested by Jani

Signed-off-by: Shobhit Kumar <shobhit.ku...@intel.com>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>

I didn't spot Jani's r-b tag in earlier mails, was that done off-list?

Yeah, was reviewed along with the other DSI patchset you merged, sorry about
that. But then some patches needed internal review while they were being
approved for up-streaming to save time. And this one was related to the
other panel driver patches which I published today so got stuck with them.
Sorry about that.

Ok, pulled it in. checkpatch complained a few times about assignments in
if conditions, and I tend to agree. Can you please follow up with a
cleanup patch? Also it looks like assignment operators could be used.
-Daniel

Ok. Thanks. I should have run checkpatch. Will fix and push a cleanup patch.

Regards
Shobhit

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to