On Mon, 27 Oct 2025, Thomas Zimmermann <[email protected]> wrote: > Hi > > Am 27.10.25 um 13:04 schrieb Jani Nikula: >> On Mon, 27 Oct 2025, Thomas Zimmermann <[email protected]> wrote: >>> Hi, >>> >>> for the series >>> >>> Reviewed-by: Thomas Zimmermann <[email protected]> >> Thanks! >> >>> Some thoughts: Consider merging patches 1 and 2 OR split off the change >>> to ttm_resource.h from patch 3. Doing the latter would make a revert of >>> the forward declaration easier in case some trees stop building. Feel >>> free to put everything into drm-misc-next if that still compiles then. >> I'm sorry, I don't understand what you're getting at. The series is >> bisectable, and in the first patch the indirect source of drm_print.h is >> drm_mm.h, and in the third patch it's ttm_resource.h. > > Sorry, I misread that. Then maybe consider splitting off those header > changes into separate patches. They could be reverted by themselves > easily without touching all the drivers. Your choice.
You mean first change all the drivers, and then nuke the includes in the headers? Okay, I can do that, though I believe it would just be easier to add the includes in the places that break. BR, Jani. > > Best regards > Thomas > >> >> BR, >> Jani. >> >> -- Jani Nikula, Intel
