On Fri, 07 Nov 2025, "Kandpal, Suraj" <[email protected]> wrote: >> > Since you have some idea why these magic numbers were chosen please >> > redo all of these, and make sure to: >> > - don't use intel_de_wait_custom() unless absolutely necessary >> > - if you need to use intel_de_wait_custom() then either >> > use the default '2,<whatever ms>' or '<whatever us>,0' timeouts >> > - document all the used timeouts. This is especially important >> > when they are not directly specified in bspec >> >> Yeah, should be intel_de_wait_for_{set,clear}() then probably. >> >> We should probably change all of those from ms to us units to make them >> more generally useful also for shorter waits. > > Sure let me take care of the lt phy and cx0 phy stuff in a separate series > then
This is what Ville followed up with [1]. BR, Jani. [1] https://lore.kernel.org/r/[email protected] -- Jani Nikula, Intel
