> Subject: [PATCH 13/16] drm/i915/de: Nuke wakelocks from
> intel_de_wait_fw_ms()
> 
> From: Ville Syrjälä <[email protected]>
> 
> The low level _fw() register accessors aren't supposed to grab the wakelock.
> Stop doing so in intel_de_wait_fw_ms().
> 
> Signed-off-by: Ville Syrjälä <[email protected]>

LGTM,
Reviewed-by: Suraj Kandpal <[email protected]>

> ---
>  drivers/gpu/drm/i915/display/intel_de.h | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_de.h
> b/drivers/gpu/drm/i915/display/intel_de.h
> index 345b27ada04f..655867ea76b8 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.h
> +++ b/drivers/gpu/drm/i915/display/intel_de.h
> @@ -146,16 +146,8 @@ intel_de_wait_fw_ms(struct intel_display *display,
> i915_reg_t reg,
>                   u32 mask, u32 value, unsigned int timeout_ms,
>                   u32 *out_value)
>  {
> -     int ret;
> -
> -     intel_dmc_wl_get(display, reg);
> -
> -     ret = __intel_wait_for_register_fw(__to_uncore(display), reg, mask,
> -                                        value, 2, timeout_ms, out_value);
> -
> -     intel_dmc_wl_put(display, reg);
> -
> -     return ret;
> +     return __intel_wait_for_register_fw(__to_uncore(display), reg, mask,
> +                                         value, 2, timeout_ms, out_value);
>  }
> 
>  static inline int
> --
> 2.49.1

Reply via email to