Hi,

On 2026-05-25 at 10:11:37 +0200, Janusz Krzysztofik wrote:
> Hi Krzysztof,
> 
> On Fri, 2026-05-22 at 17:43 +0200, Krzysztof Niemiec wrote:
> > During driver probe, in i915_driver_register(), if drm_dev_register()
> > fails, the code enters into an error path. In it, a call to
> > drm_dev_unregister() is made as part of cleanup in case drm_dev_register()
> > returns an error. However, this is unnecessary, as in case of an error
> > drm_dev_register() undoes its own setup in its own error path.
> 
> Doesn't this patch depend on your "drm: Set dev->registered back to false
> in case of register failure"?  While each of the two touches a separate
> area of responsibility, I would submit them as a series if that dependency
> exists.
> 
> Thanks,
> Janusz
> 

+1 to Janusz's suggestion, these should be made into a series.

-- 
Best Regards,
Krzysztof

Reply via email to