> Subject: [PATCH v4 10/10] drm/i915/bios: remove VS/PE-O warning > > There is not much use of warning when port asks to override default VS/PE > since it is already logged. Remove drm_WARN() and child_device from > print_ddi_port() since drm_WARN() was the only user of it. >
LGTM, Reviewed-by: Suraj Kandpal <[email protected]> > Signed-off-by: Michał Grzelak <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_bios.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c > b/drivers/gpu/drm/i915/display/intel_bios.c > index 6adec6e60df3..1eb588712ed3 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -2769,7 +2769,6 @@ static bool is_port_valid(struct intel_display > *display, enum port port) static void print_ddi_port(const struct > intel_bios_encoder_data *devdata) { > struct intel_display *display = devdata->display; > - const struct child_device_config *child = &devdata->child; > bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, > supports_tbt; > int dp_boost_level, dp_max_link_rate, hdmi_boost_level, > hdmi_level_shift, max_tmds_clock; > enum port port; > @@ -2842,14 +2841,6 @@ static void print_ddi_port(const struct > intel_bios_encoder_data *devdata) > drm_dbg_kms(display->drm, > "Port %c VBT DP max link rate: %d\n", > port_name(port), dp_max_link_rate); > - > - /* > - * FIXME need to implement support for VBT > - * vswing/preemph tables should this ever trigger. > - */ > - drm_WARN(display->drm, child->use_vbt_vswing, > - "Port %c asks to use VBT vswing/preemph tables\n", > - port_name(port)); > } > > static void parse_ddi_port(struct intel_bios_encoder_data *devdata) > -- > 2.45.2
