> -----Original Message-----
> From: Manna, Animesh <[email protected]>
> Sent: Tuesday, June 16, 2026 1:33 AM
> To: [email protected]; [email protected]
> Cc: Shankar, Uma <[email protected]>; Dibin Moolakadan Subrahmanian
> <[email protected]>; [email protected];
> Nikula, Jani <[email protected]>; Manna, Animesh
> <[email protected]>
> Subject: [PATCH v9 11/22] drm/i915/display: Rename cpu_transcoder parameter
> to transcoder in VRR fixed-rr path
> 
> intel_vrr_set_fixed_rr_timings() now takes the target transcoder as an 
> explicit
> argument rather than implicitly using crtc_state->cpu_transcoder, so the
> parameter name 'cpu_transcoder' is misleading. Rename it to plain 
> 'transcoder' to
> reflect that any transcoder may be programmed.
> 
> No functional change.

Looks Good to me.
Reviewed-by: Uma Shankar [email protected]>

> Signed-off-by: Animesh Manna <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_vrr.c | 8 ++++----
> drivers/gpu/drm/i915/display/intel_vrr.h | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 60a92e8b1094..401a12aee700 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -320,18 +320,18 @@ int intel_vrr_fixed_rr_hw_flipline(const struct
> intel_crtc_state *crtc_state)  }
> 
>  void intel_vrr_set_fixed_rr_timings(const struct intel_crtc_state 
> *crtc_state,
> -                                 enum transcoder cpu_transcoder)
> +                                 enum transcoder transcoder)
>  {
>       struct intel_display *display = to_intel_display(crtc_state);
> 
>       if (!intel_vrr_possible(crtc_state))
>               return;
> 
> -     intel_de_write(display, TRANS_VRR_VMIN(display, cpu_transcoder),
> +     intel_de_write(display, TRANS_VRR_VMIN(display, transcoder),
>                      intel_vrr_fixed_rr_hw_vmin(crtc_state) - 1);
> -     intel_de_write(display, TRANS_VRR_VMAX(display, cpu_transcoder),
> +     intel_de_write(display, TRANS_VRR_VMAX(display, transcoder),
>                      intel_vrr_fixed_rr_hw_vmax(crtc_state) - 1);
> -     intel_de_write(display, TRANS_VRR_FLIPLINE(display, cpu_transcoder),
> +     intel_de_write(display, TRANS_VRR_FLIPLINE(display, transcoder),
>                      intel_vrr_fixed_rr_hw_flipline(crtc_state) - 1);  }
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h
> b/drivers/gpu/drm/i915/display/intel_vrr.h
> index 57c5e28378db..55e9c429f579 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.h
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.h
> @@ -44,7 +44,7 @@ bool intel_vrr_is_fixed_rr(const struct intel_crtc_state
> *crtc_state);  void intel_vrr_transcoder_enable(const struct intel_crtc_state
> *crtc_state);  void intel_vrr_transcoder_disable(const struct intel_crtc_state
> *crtc_state);  void intel_vrr_set_fixed_rr_timings(const struct 
> intel_crtc_state
> *crtc_state,
> -                                 enum transcoder cpu_transcoder);
> +                                 enum transcoder transcoder);
>  void intel_vrr_dcb_reset(const struct intel_crtc_state *old_crtc_state,
>                        struct intel_crtc *crtc);
>  bool intel_vrr_always_use_vrr_tg(struct intel_display *display);
> --
> 2.29.0

Reply via email to