> -----Original Message-----
> From: Dibin Moolakadan Subrahmanian
> <[email protected]>
> Sent: Tuesday, June 16, 2026 9:52 PM
> To: [email protected]; [email protected]
> Cc: Shankar, Uma <[email protected]>; Manna, Animesh
> <[email protected]>; [email protected]
> Subject: [PATCH v6 15/16] drm/i915/display: Guard CMTG function calls
>
> Check if DC3CO is allowed before calling CMTG functions in
> intel_atomic_commit_tail() as CMTG is only used by DC3CO DC state.
>
> Signed-off-by: Dibin Moolakadan Subrahmanian
> <[email protected]>
LGTM.
Reviewed-by: Animesh Manna <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index ddcf2d2054b7..3b17ce669ac5 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7579,10 +7579,8 @@ static void intel_atomic_commit_tail(struct
> intel_atomic_state *state)
> /* FIXME probably need to sequence this properly */
> intel_program_dpkgc_latency(state);
>
> - /*
> - * TODO: DC3co entry condition need to be checked before calling
> CMTG functions.
> - */
> - intel_cmtg_program(state);
> + if (intel_display_power_dc3co_allowed(display))
> + intel_cmtg_program(state);
>
> intel_wait_for_vblank_workers(state);
>
> --
> 2.43.0
