On Mon, 15 Jun 2026, Michał Grzelak <[email protected]> wrote: > Scaler allocation fails returning -1 which equates to -EPERM. Return > -EINVAL instead. Also apply for skl_pipe_scaler_get_hw_state(). > > Fixes: e2255e9a5a77 ("drm/i915/scaler: abstract scaler searching loop") > Fixes: ecf2afc59c1e ("drm/i915/scaler: Extract intel_allocate_scaler()")
Same as in patch 1. There is no bug that needs fixing. The trailers are superfluous. Reviewed-by: Jani Nikula <[email protected]> > Cc: Nemesa Garg <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Suggested-by: Jani Nikula <[email protected]> > Signed-off-by: Michał Grzelak <[email protected]> > --- > drivers/gpu/drm/i915/display/skl_scaler.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c > b/drivers/gpu/drm/i915/display/skl_scaler.c > index 0cfa5b7564ba8..c339fdd6936fa 100644 > --- a/drivers/gpu/drm/i915/display/skl_scaler.c > +++ b/drivers/gpu/drm/i915/display/skl_scaler.c > @@ -351,7 +351,7 @@ static int intel_allocate_scaler(struct > intel_crtc_scaler_state *scaler_state, > return scaler_id; > } > > - return -1; > + return -EINVAL; > } > > static void > @@ -848,7 +848,7 @@ static int skl_pipe_scaler_get_hw_state(struct > intel_crtc_state *crtc_state) > return scaler_id; > } > > - return -1; > + return -EINVAL; > } > > void -- Jani Nikula, Intel
