On Mon, May 19, 2014 at 08:54:04PM +0530, Shashank Sharma wrote:
> Re-define MIPI register definitions in such a way that most of
> the existing DSI code can be re-used for future platforms. Register
> definitions are re-written using MMIO offset variable, so that without
> changing the existing sequence, same code can be generically applied.
>
> Signed-off-by: Shashank Sharma <[email protected]>
Two little things:
* You changed the _PIPE() macro to something with a jump, can we please
not introduce branches here? might as well keep the _PIPE() macro,
even if _TRANSCODER() would be slightly better (but strickly
equivalent
* You've cut everything to be < 80 chars. I really think that's one of
the cases where it's worse, ie:
#define _MIPIB_DSI_FUNC_PRG (dev_priv->mipi_mmio_base + \
0xb80c)
#define MIPI_DSI_FUNC_PRG(check) (!check ? \
_MIPIA_DSI_FUNC_PRG : _MIPIB_DSI_FUNC_PRG)
Vs
#define _MIPIB_DSI_FUNC_PRG (dev_priv->mipi_mmio_base + 0xb80c)
#define MIPI_DSI_FUNC_PRG(pipe) _PIPE(pipe, _MIPIA_DSI_FUNC_PRG,
_MIPIB_DSI_FUNC_PRG)
Can we not do that?
--
Damien
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
