Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/i915/psr: macro rename introduces new typo _CONTINOUOS_ --
commit 6ee099cfe2ac28d1b7981063a5dd7a20aa5f8373 Author: Michał Grzelak <[email protected]> drm/i915/psr: clean register macro's name from typo This commit renames ADLP_PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME and PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME to fix a spelling typo in the register macro names. > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/drivers/gpu/drm/i915/display/intel_psr.c > index f7fae75751f54..2fd77313971be 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1074,7 +1074,7 @@ static void dg2_activate_panel_replay(struct intel_dp > *intel_dp) > > intel_de_rmw(display, > PSR2_MAN_TRK_CTL(display, intel_dp->psr.transcoder), > - 0, ADLP_PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME); > + 0, ADLP_PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME); > > intel_de_rmw(display, TRANS_DP2_CTL(intel_dp->psr.transcoder), > dp2_ctl_clear, dp2_ctl_set); > } > @@ -2618,8 +2618,8 @@ static u32 man_trk_ctl_partial_frame_bit_get(struct > intel_display *display) > static u32 man_trk_ctl_continuous_full_frame(struct intel_display *display) > { > return display->platform.alderlake_p || DISPLAY_VER(display) >= 14 ? > - ADLP_PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME : > - PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME; > + ADLP_PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME : > + PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME; > } > > static void intel_psr_force_update(struct intel_dp *intel_dp) > diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h > b/drivers/gpu/drm/i915/display/intel_psr_regs.h > index a57bc111290d1..56df4d2f97286 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h > +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h > @@ -241,7 +241,7 @@ > #define PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR_MASK REG_GENMASK(20, > 11) > #define PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR(val) > REG_FIELD_PREP(PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR_MASK, val) > #define PSR2_MAN_TRK_CTL_SF_SINGLE_FULL_FRAME > REG_BIT(3) > -#define PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME REG_BIT(2) > +#define PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME REG_BIT(2) > #define PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE REG_BIT(1) > #define ADLP_PSR2_MAN_TRK_CTL_SU_REGION_START_ADDR_MASK REG_GENMASK(28, > 16) > #define ADLP_PSR2_MAN_TRK_CTL_SU_REGION_START_ADDR(val) > REG_FIELD_PREP(ADLP_PSR2_MAN_TRK_CTL_SU_REGION_START_ADDR_MASK, val) > @@ -249,7 +249,7 @@ > #define ADLP_PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR(val) > REG_FIELD_PREP(ADLP_PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR_MASK, val) > #define ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE > REG_BIT(31) > #define ADLP_PSR2_MAN_TRK_CTL_SF_SINGLE_FULL_FRAME REG_BIT(14) > -#define ADLP_PSR2_MAN_TRK_CTL_SF_CONTINUOS_FULL_FRAME > REG_BIT(13) > +#define ADLP_PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME > REG_BIT(13) [Severity: Low] This isn't a bug, but should _CONTINOUOS_ be _CONTINUOUS_ in PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME and ADLP_PSR2_MAN_TRK_CTL_SF_CONTINOUOS_FULL_FRAME (as well as their callers dg2_activate_panel_replay() and man_trk_ctl_continuous_full_frame()), matching LNL_CFF_CTL_SF_CONTINUOUS_FULL_FRAME? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
