On Tue, Sep 30, 2014 at 10:55:35PM +0200, Daniel Vetter wrote:
> With the structured logging it makes more sense to tune this down a
> bit. Also, this way it is consistent with Thomas Wood's new activity
> indicator helper.
> 
> Spotted while discussing Thomas' patch with him.
> 
> v2: Thomas noticed that I've forgotten the fflush. Extract
> igt_interactive_info for both igt_progress and igt_print_activity.
> 
> v3: Interactive output should go to stderr. Also extract the "is this
> a terminal" check.
> 
> Cc: Thomas Wood <[email protected]>
> Cc: Chris Wilson <[email protected]>
> Signed-off-by: Daniel Vetter <[email protected]>

Not reusing the igt_warn() is great as well (we had earlier problems
when igt_warn* became smarter...)

Nothing to complain about here, lgtm.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to