On Fri, Nov 06, 2015 at 03:08:32PM +0200, [email protected] wrote: > From: Ville Syrjälä <[email protected]> > > We set up fbdev last during load, so doing the fbdev cleanup should be > first. > > We weren't supposed to drop the init power during driver load, but since > the fbdev teardown happened after intel_power_domains_fini() that could > have happened due in one of two ways. First it could have happened > during the modeset caused by normal fbdev cleanup. But in addition it > could have happened already via the intel_fbdev_initial_config() since > that is executed asynhronously, and the async_synchronize_full() was > done during fbdev cleanup, after intel_power_domains_fini(). All of > that got eliminated by > commit 292b990e86abc ("drm/i915: Update power domains on readout.") > since we now drop the init power synchronously during driver load. > > So there is no real bug wrt. the init power anymore, but still it seems > better to do the fbdev cleanup first, before we've potentially cleaned > up something else important. > > Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Chris Wilson <[email protected]> Hmm, a good onion and some nice cheese make a fine sandwich. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
