On Thu, Dec 10, 2015 at 06:51:25PM +0000, Dave Gordon wrote: > Currently, the target object being written *may* be marked dirty, either > in i915_gem_gtt_pwrite_fast() (as a side-effect of setting its domain to > GTT!), or in i915_gem_shmem_pwrite() (if it's a shmfs-backed object). > While these two are the common cases, it's not obvious that they cover > every possible path through the pwrite code, for every possible type > of object (e.g. phys, stolen, etc). So here we move setting-the-mark > to the top level so that it is obvious that it applies no matter which > subsequent path is followed. > > Signed-off-by: Dave Gordon <[email protected]> > Cc: Chris Wilson <[email protected]>
I don't like this patch - I feel like it divorces the information that we are dirtying the pages from the actual copy. Especially as some paths don't actually dirty the object's backing storage (for extra confusion). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
