On Thu, May 12, 2016 at 01:15:43PM +0100, Tvrtko Ursulin wrote: > > On 12/05/16 12:43, Chris Wilson wrote: > >Another day, another long overdue conversion. Not much to update inside > >intel_overlay.c, but still > > > > text data bss dec hex filename > >6309547 3578778 696320 10584645 a18245 vmlinux > >6309291 3578778 696320 10584389 a18145 vmlinux > > > >a couple of hundred bytes of pointer misdirection. > > > >Whilst here, rename the ioctl entry points to include the _ioctl suffix > >so that the user entry points are clear (following the idiom). > > > >Signed-off-by: Chris Wilson <[email protected]> > >--- > > drivers/gpu/drm/i915/i915_dma.c | 4 +- > > drivers/gpu/drm/i915/intel_display.c | 4 +- > > drivers/gpu/drm/i915/intel_drv.h | 12 ++-- > > drivers/gpu/drm/i915/intel_overlay.c | 132 > > ++++++++++++++++------------------- > > 4 files changed, 70 insertions(+), 82 deletions(-) > > > > intel_setup_overlay might be tidier with a local variable for dev > since it is used a good number of times, but either way:
Long term is that those callsites also use drm_i915_private. Having lots of dev_priv->dev is a good motivator for which paths to prioritse. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
