> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Vitaly Lifshits
> Sent: Tuesday, December 23, 2025 10:51 AM
> To: [email protected]
> Cc: Lifshits, Vitaly <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1 1/2] e1000e: introduce
> new MAC type for Panther Lake PCH
>
The commit title mentions "MAC type" but the patch introduces both a board
type (board_pch_ptp) and a MAC type (e1000_pch_ptp), plus it remaps several
PCI device IDs from board_pch_mtp to board_pch_ptp.
Since board types and MAC types serve distinct purposes in e1000e (PCI ID
mapping vs. feature gating), consider clarifying the title to reflect both:
e1000e: introduce new board and MAC types for Panther Lake PCH
This makes it clearer for future git-log searches and helps reviewers
understand the scope of changes.
> Add new MAC type for Panther Lake devices for separating device-
> specific features and flows.
> Additionally, remove the discontinued device IDs: 0x57B5, 0x57B6.
>
> Fixes: 0c9183ce61bc ("e1000e: Add support for the next LOM
> generation")
> Signed-off-by: Vitaly Lifshits <[email protected]>
> ---
> drivers/net/ethernet/intel/e1000e/e1000.h | 4 +++-
> drivers/net/ethernet/intel/e1000e/hw.h | 2 --
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 20 ++++++++++++++++++++
> drivers/net/ethernet/intel/e1000e/netdev.c | 15 +++++++--------
> 4 files changed, 30 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h
> b/drivers/net/ethernet/intel/e1000e/e1000.h
> index aa08f397988e..63ebe00376f5 100644
> --- a/drivers/net/ethernet/intel/e1000e/e1000.h
> +++ b/drivers/net/ethernet/intel/e1000e/e1000.h
> @@ -117,7 +117,8 @@ enum e1000_boards {
> board_pch_cnp,
> board_pch_tgp,
> board_pch_adp,
> - board_pch_mtp
> + board_pch_mtp,
> + board_pch_ptp
> };
>
> struct e1000_ps_page {
> @@ -527,6 +528,7 @@ extern const struct e1000_info e1000_pch_cnp_info;
> extern const struct e1000_info e1000_pch_tgp_info; extern const
> struct e1000_info e1000_pch_adp_info; extern const struct e1000_info
> e1000_pch_mtp_info;
> +extern const struct e1000_info e1000_pch_ptp_info;
> extern const struct e1000_info e1000_es2_info;
>
> void e1000e_ptp_init(struct e1000_adapter *adapter); diff --git
> a/drivers/net/ethernet/intel/e1000e/hw.h
> b/drivers/net/ethernet/intel/e1000e/hw.h
> index fc8ed38aa095..c7ac599e5a7a 100644
> --- a/drivers/net/ethernet/intel/e1000e/hw.h
> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
> @@ -118,8 +118,6 @@ struct e1000_hw;
> #define E1000_DEV_ID_PCH_ARL_I219_V24 0x57A1
> #define E1000_DEV_ID_PCH_PTP_I219_LM25 0x57B3
> #define E1000_DEV_ID_PCH_PTP_I219_V25 0x57B4
> -#define E1000_DEV_ID_PCH_PTP_I219_LM26 0x57B5
> -#define E1000_DEV_ID_PCH_PTP_I219_V26 0x57B6
Commit message states "remove the discontinued device IDs: 0x57B5, 0x57B6"
but provides no justification or reference for why they are discontinued.
If these IDs were publicly announced or shipped in hardware, removing them may
break existing systems.
Please clarify!
> #define E1000_DEV_ID_PCH_PTP_I219_LM27 0x57B7
> #define E1000_DEV_ID_PCH_PTP_I219_V27 0x57B8
> #define E1000_DEV_ID_PCH_NVL_I219_LM29 0x57B9
> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c
...
> --
> 2.34.1
