> /* Read sync Admin Command response */
> - if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + if ((hicr & IXGBE_PF_HICR_SV))
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
Did you look through the history? When i see code like this it makes
me want to have an understanding why it exists, since it looks so odd.
Is it a merge conflict resolution gone bad? Is it a typo and there is
a cooked_desc[i] which could be set?
> /* Read async Admin Command response */
> - if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C))
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
and it exists twice. Which makes it even odder....
Andrew
