> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Piotr Kwapulinski
> Sent: Thursday, January 29, 2026 6:55 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Kwapulinski, Piotr
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next] ixgbe: e610: remove
> redundant assignment
>
> Remove unnecessary code. No functional impact.
>
> Fixes: 46761fd52a88 ("ixgbe: Add support for E610 FW Admin Command
> Interface")
> Signed-off-by: Piotr Kwapulinski <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index c2f8189..6f380fc 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -142,20 +142,14 @@ static int ixgbe_aci_send_cmd_execute(struct
> ixgbe_hw *hw,
> IXGBE_PF_HICR);
>
> /* Read sync Admin Command response */
> - if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + if ((hicr & IXGBE_PF_HICR_SV))
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> - }
>
> /* Read async Admin Command response */
> - if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C))
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
> - }
>
> /* Handle timeout and invalid state of HICR register */
> if (hicr & IXGBE_PF_HICR_C)
> --
> 2.47.1
Reviewed-by: Aleksandr Loktionov <[email protected]>
