On 2/5/2026 12:35 AM, Kwapulinski, Piotr wrote:
-----Original Message-----
From: Keller, Jacob E <[email protected]>
Sent: Thursday, January 29, 2026 7:11 PM
To: Andrew Lunn <[email protected]>; Kwapulinski, Piotr
<[email protected]>
Cc: [email protected]; [email protected];
[email protected]; [email protected]; [email protected]
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ixgbe: e610: remove redundant
assignment
I actually don't know which is "correct", as I don't really understand what the
register interface expects, and how it will get interpreted by the firmware...
Maybe the byteswap of each 4-byte block is right? but I'm really uncertain
now...
Presumably it expects flags first and then opcode? we're writing it that way
now on a LE system.. But on a BE system thats going to be byteswapped before
going into the register.. so our 4byte chunk would end up potentially reversing
the flags and opcode w.r.t what the firmware sees??
Hmm.....
I'll work out the solution. Meanwhile, possibly it's good idea to take this
patch since this code is unnecessary regardless of the final outcome.
Thanks,
Piotr
Makes sense to me.
Thanks,
Jake
[...]
