At 06:03 PM 2/16/2004 +0200, Jani Taskinen wrote:
On Mon, 16 Feb 2004, Andi Gutmans wrote:

>It seems to me that the difference is in the dtor() callback's parameters.
>I'm not sure why type_name is not passed to
>zend_register_list_destructors(). It probably did not exist when it was
>originally written.

Zeev might know? :)

>I guess we can either fix the comparison, change
>zend_register_list_destructors() to accept type_name, or nuke
>zend_register_list_destructors() completely and move to _ex().
>Probably the last is the best option if we only have to fix two extensions.

Wouldn't it be best to fix the comparison in PHP 4 and 5 and
nuke the function in PHP 5? This would let possible 3rd party extensions
use the old macro, but not cause any crashes with the zend_fetch_list_dtor_id()
calls..

I don't understand. Why fix it in PHP 5 if you're suggesting to nuke the function? :)



And change the extensions that use the register_list_destructors() macro to use the _ex() function.

That can't be done. The callback prototypes are different.


Andi

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to