On Wed, 18 Feb 2004, Andi Gutmans wrote:
>At 08:20 AM 2/18/2004 +0200, Jani Taskinen wrote:
>>On Wed, 18 Feb 2004, Andi Gutmans wrote:
>>
>> >At 12:01 AM 2/18/2004 +0200, Jani Taskinen wrote:
>> >> >That's fine. I thought you meant to make register_list_destructors() call
>> >> >register_list_destructors_ex().
>> >>
>> >> It seems that nuking is out of question and not very good idea after
>> >> all. ;)
>> >> Using zend_register_list_destructors() (or the macro,
>> >> register_list_destructors),
>> >> might be valid in some cases and the real bug is only in the
>> >> zend_fetch_list_dtor_id()
>> >> function which really should ignore the 'unnamed resources'.
>> >>
>> >> See ext/soap for more..
>> >
>> >I don't quite understand. Why can't the SOAP module give type_names for
>> >these resources? e.g. "sdl", "url", "service".
>> >What am I missing?
>>
>> Those resources are not used anywhere outside the extension..
>> so why should they be named? (AFAICS, they're never returned anywhere
>> to user)
>
>That doesn't matter IMO. I think it's OK if we require people to give a
>name to their resources. It will also make it easier to debug their extensions.
Ok.
>> And using the zend_register_list_destructors() you can avoid
>> unnecessary casting from zend_rsrc_list_entry to the desired type.
>> (I'm of course guessing here :)
>
>Yeah but you also get TSRMLS_CC :)
Heh, that's true. :)
Maybe the first step is to just remove the register_list_destructors macro?
That should give a noticeable heads-up-call for the maintainers of ext/mssql
and ext/soap.. :)
(I can patch ext/mssql, just can't test the changes in action :)
--Jani
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
