On Tue, Feb 25, 2020 at 9:59 AM Nikita Popov <nikita....@gmail.com> wrote:
> On Thu, Feb 13, 2020 at 10:47 AM Nikita Popov <nikita....@gmail.com> wrote: > > > This has been discussed a while ago already, now as a proper proposal: > > https://wiki.php.net/rfc/token_as_object > > > > An open question is whether (at least to start with) PhpToken should be > > just a data container, or whether we want to add some helper methods to it. > > If this generates too much bikeshed, I'll drop methods from the proposal. > > I think this proposal is in a pretty decent shape now, and I'd like to move > it to voting soon. The only remaining open question is whether we want to > add any additional predefined methods. As the class can now be extended, > every library can add their own methods, but there might still be value in > providing some things by default, primarily for performance reason. For > example, the proposed is() method can be a good bit more efficient when > implemented directly in extension code. > > Any feedback on this point? Hi Nikita, Thanks for this RFC. The proposed `PhpToken` class will definitely make it easier to work with parsed tokens (I struggled with this when working on the migration script for deprecated alternate array/string offset syntax). In regards to the open question of additional methods, the `getTokenName()` method would be very welcome. `isIgnorable()` would also be helpful sometimes, though I don't care much one way or another if it's added. But I'm really skeptical about the value of the `is($kind)` method. Code working with tokens should know the type of value being checked (ID int, text content, or array of one or the other), and a method that accepts any of three types can make it harder to understand what's going on. For example, the proposed `isIgnorable()` method doesn't need to use `is()`, it could just check whether the `id` property is in the array of token constants. Best regards, Theodore -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
