I'm a bit out of the loop on the higher level discussion, but as I got named dropped here, a quick note...
On Tue, Feb 28, 2023, at 23:21, Max Kellermann wrote: > On 2023/02/28 22:31, Dmitry Stogov <dmitrysto...@gmail.com> wrote: > > https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa > > This kind of change was favored by a supermajority. > > You argue that this supermajority vote is irrelevant, and formally it > indeed is, but pondering about formalities is kind of ignorant against > the now well-known community opinion. > > > https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c79d > > No vote was made on this, therefore this doesn't violate any community > rules, does it? > > If you think this should be reverted, explain why. > > > https://github.com/php/php-src/commit/42577c6b6b7577c57c161ee4a74cb193382bf1e0 > > Favored by supermajority, see above. > > > https://github.com/php/php-src/commit/c7637ed1c03f556c6fb65884cfc5bfea4920b1c7 > > No vote, no rule violation, see above. This commit broke a valuable debugging reference: I used to often check these defines to determine what a type code means. If you get type 18, good luck figuring out what that means now. > > > https://github.com/php/php-src/commit/371ae12d890f1887f79b7e2a32f808b4595e5f60 > > As you see in the commit message, this implements an (unwritten) rule > cited by Nikita Popov (which is now written as of > https://github.com/php/php-src/pull/10630). I personally don't agree > with this rule (there's a thread on this mailing list about it), and I > would favor reverting this commit - I only submitted this trying to > help with implementing a rule even though I don't agree with it. This is a pretty cherry-picked statement. In that mailing list thread I explicitly pointed out that while this is the rule (and if you introduce new code, that would be the convention to follow), that does not necessarily mean that it's a good idea to fix existing cases that don't follow it. I also pointed out that for public APIs, this is a very insidious API break, because it doesn't make using code fail to compile: It just silently inverts the result from it's previous meaning. It looks like those parts of my mail just got ignored. Regards, Nikita > If this gets reverted, then https://github.com/php/php-src/pull/10630 > should be reverted as well. Again, not my opinion, I'm just trying to > help implement somebody else's opinion. > > Max > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > >
