On 2023/02/28 23:33, Max Kellermann <max+...@blarg.de> wrote: > > Include cleanups RFC was rejected. > > No refactoring RFC was presented. > > A lot of changes that affect all core contributors are committed into > > master. > > Do you mean to imply that code changes that do not implement RFC or > fix a bug should always be rejected?
CONTRIBUTING.md says: "PHP welcomes pull requests to add tests, fix bugs and to implement RFCs." Indeed it appears Dmitry is right - code refactoring is generally NOT allowed (unless there is an explicit RFC vote, and I havn't seen one). This implies that all those commits (and hundreds of others): > > https://github.com/php/php-src/commit/4177257178d6a1a44f0aa6d6b23d02b91e0a58d3 > > https://github.com/php/php-src/commit/9108a32bfe881c3b1e2f3b2949b0e9fe1b9c6dda > https://github.com/php/php-src/commit/07fe46fb5db9d6f34e72f513ae053fc8c9ad67a > > https://github.com/php/php-src/commit/900472536775b71d5d72a0d66eaa46ae7c7d7ad9 > > https://github.com/php/php-src/commit/f0cfebc2b867a6a96a88c4526cf9f3b4cd01f04b > > https://github.com/php/php-src/commit/f079aa2e242b251c6297bddf5365c33c126b7dcc > > https://github.com/php/php-src/commit/b14dd85dca3b67a5462f5ed9b6aa0dc22beb615c ... should not have been merged! Where do we go from here? Really revert EVERYTHING? (Reverting just my code refactoring changes but nobody else's would make no sense at all. Don't make this personal.) Max -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
